Added filters page and link from how-tos #158
Conversation
Filters page that: - adapts the govuk prototype kit guidance for using or making filters https://prototype-kit.service.gov.uk/docs/filters and adapts to an earlier version of the kit (particularly for formatting html in filters) - includes the guidance for dates using xgovuk filters https://prototype-kit.service.gov.uk/docs/date-filters by merging it into the same page I have tried running this all locally and it seems to work
frankieroberto
temporarily deployed
to
nhs-prototyp-98-add-a-g-tmpl26
vickytnz
requested review from
edwardhorsford,
frankieroberto and
anandamaryon1
and removed request for
anandamaryon1
|
How to page with basic information Simplified page |
Co-authored-by: Ed Horsford <[email protected]>
Co-authored-by: Ed Horsford <[email protected]>
|
Hmm after looking properly at the Nunjucks documentation for filters: I wonder if this page should get held back unpublished until we can update the filters page to properly work as documented in the guidance? Or I have to do a disclaimer that the documentation won't work which .... isn't great. UPDATE: now understand how these connect and have updated guidance. |
|
New version: How-to pageMinor tweak to language PagePretty big changes including:
|
|
Arrgh I've realised that the docs kit doesn't have an up-to-date filters page so there is a lot of stuff there that I didn't know was there. Redoing the code examples based on the exact examples that are there. |
|
New version: How-to pageMinor tweak to language PageNow has
|
Noticed that the comments in `app/filters.js` mention "gov.uk core filters" - presumably leftover from forking from the govuk prototype kit. Have taken the opportunity to simplify the comments blocks. The middle comments block could be updated to point to some guidance on https://prototype-kit.service-manual.nhs.uk when it’s ready. Spotted when reviewing nhsuk/nhsuk.service-manual.prototype-kit.docs#158
frankieroberto
temporarily deployed
to
nhs-prototyp-98-add-a-g-wvkzg0
|
Hi @vickytnz, re the page about filters. It feels very complex to me. I'm wondering whether we should have a basic usage section and an advanced usage section as GOV does: https://prototype-kit.service.gov.uk/docs/tutorials-and-guides. Perhaps with branching being advanced too? Did you consider this? If we do keep it in for advanced users, I suspect that we need to explain in more detail what "filters" are here. It's taken me a while to work it out. I was thinking more about filters in the sense of filtering a list. I can do a content review next week. |
Filters page that:
I have tried running this all locally and it seems to work.
Section in how-tos
Filters page
This page may be running long but i am positioning it for now as a way to understand filters. It could be that this gets split, however I also wonder if this shows that the filters part of the kit needs to get updated to make it in line with the current govuk kit.